Add anchor link for each request in the report to make it easily shareable #317
Conversation
* add behavior to scroll to endpoint div using #id in url and open it
Thank you for supporting ScanAPI, and congratulations on your first contribution! A project committer will shortly review your contribution.
In the mean time, if you haven't had a chance please skim over the First Pull Request Guide which all pull requests must adhere to.
We hope to see you around!
Hey! Thank you very much for your PR. I tested it here for different browsers and it works great
I believe we can create new issues for the topics you pointed out. What do you think? I will create the one for the link right now.
I've just left one minor suggestion.
Co-authored-by: Camila Maia <cmaiacd@gmail.com>
|
So glad it worked! Was a pleasure to work on this issue and will be a pleasure to work on the "link' one if possible. I've just commited your suggestion. |
|
@djalmaaraujo would you mind helping me review this one? |
|
Hey, @pxd3v thank you very much for the PR! Also, I am going to send you an invite to join the ScanAPI org on GitHub And once again, thank you! |
|
Hi @camilamaia! it was a pleasure. I already accepted the invite, thank you so much!! :))) |
…eable (scanapi#317) Add anchor to each endpoint on Report
Hi everyone! I just implemented an solution for this issue: #260. The feature is already working, you just need to add the endpoint list index to the url and it's gonna open the page in the correct endpoint, e.g. url:
Documents/scan-api/scanapi/scanapi-report.html#endpoint_4.I think that we have 2 more things to implement here:
I noticed another thing when editing the template HTML file, maybe would be more acessible if we start using an
<ul>tag for the endpoints wrapper and<li>tags for the endpoints with proper key properties instead of<div>'s.Let me know your thoughts!