Adds flake8 checks and configs #322 #323
Conversation
lint checks combined into .github/workflows/lint.yml
Thank you for supporting ScanAPI, and congratulations on your first contribution! A project committer will shortly review your contribution.
In the mean time, if you haven't had a chance please skim over the First Pull Request Guide which all pull requests must adhere to.
We hope to see you around!
@NimishVerma thank you for the PR! I left some comments. Also, would you mind updating your branch with master?
Thanks!
hey @marcuxyz, thanks! This commit you pointed out was for the github action check. This PR is for the pre-commit hook. The problem is that the branch is outdated. |
Co-authored-by: Camila Maia <cmaiacd@gmail.com>
Co-authored-by: Camila Maia <cmaiacd@gmail.com>
.github/workflows/lint.yml
Outdated
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - name: "Black Code Formatter" |
.github/workflows/lint.yml
Outdated
| @@ -1,12 +1,22 @@ | |||
| on: pull_request | |||
| name: Lint check | |||
| name: Lint checks | |||
There was a problem hiding this comment.
Hey, @NimishVerma I believe this file .github/workflows/lint.yml should not be changed. Probably a problem merging master into the branch. I understand this PR should only change the .pre-commit-config.yaml file.
|
Hey, @NimishVerma thank you very much for the PR! Also, I am going to send you an invite to join the ScanAPI org on GitHub And once again, thank you! |
Added flake8 to pre-commit
No description provided.