★ wanayoo — archive 1999 https://github.com/slimphp/Slim/pull/2014Nouvelle recherche | Portail wanayoo
Skip to content

/ Slim

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more status codes #2014

Merged
merged 2 commits into from Nov 18, 2016
Merged

Add more status codes #2014

merged 2 commits into from Nov 18, 2016

Conversation

@akrabat
Copy link
Member

@akrabat akrabat commented Oct 12, 2016

No description provided.

@coveralls
Copy link

@coveralls coveralls commented Oct 12, 2016

Coverage Status

Coverage decreased (-0.06%) to 97.139% when pulling 85a3ad8 on akrabat:more-http-codes into 2f29cc2 on slimphp:3.x.
@akrabat
Add more status codes
Loading status checks…
343b939
@akrabat akrabat force-pushed the akrabat:more-http-codes branch from 85a3ad8 to 343b939 Oct 12, 2016
@coveralls
Copy link

@coveralls coveralls commented Oct 12, 2016

Coverage Status

Coverage decreased (-0.06%) to 97.139% when pulling 343b939 on akrabat:more-http-codes into 2f29cc2 on slimphp:3.x.
@prisis
Copy link

@prisis prisis commented Oct 12, 2016

Maybe you like this package from me, it has all status codes. https://github.com/narrowspark/http-status
@robertprice
Copy link
Contributor

@robertprice robertprice commented Oct 13, 2016

You need to update testMustSetReasonPhraseForUnrecognisedCode in ResponseTest.php as it's testing for 499 as an unrecognised code, but as this has now been defined a new code is needed. This will get the phpunit tests passing again.
@akrabat
Copy link
Member Author

@akrabat akrabat commented Oct 14, 2016

Yeah - hoping to get to it today.
@akrabat
Update unit tests
Loading status checks…
ac7717c 
Use 199 now that 499 is a valid status code.
@akrabat akrabat force-pushed the akrabat:more-http-codes branch from 0b3bdf4 to ac7717c Oct 14, 2016
@coveralls
Copy link

@coveralls coveralls commented Oct 14, 2016

Coverage Status

Coverage increased (+0.002%) to 97.2% when pulling ac7717c on akrabat:more-http-codes into 2f29cc2 on slimphp:3.x.
@coveralls
Copy link

@coveralls coveralls commented Oct 14, 2016

Coverage Status

Coverage increased (+0.002%) to 97.2% when pulling ac7717c on akrabat:more-http-codes into 2f29cc2 on slimphp:3.x.
@akrabat akrabat added this to the 3.6.0 milestone Nov 18, 2016
@silentworks
silentworks approved these changes Nov 18, 2016
View changes
@silentworks silentworks merged commit 66ff172 into slimphp:3.x Nov 18, 2016
3 checks passed
3 checks passed
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 97.2%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silentworks silentworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@akrabat @coveralls @prisis @robertprice @silentworks