Reuse getParsedBodyParam for determining method override in POST body. #2034
Conversation
|
Yes. |
|
Thanks. |
|
You're welcome, and thanks for accepting my little contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Makes
getMethod()internally usegetParsedBodyParam()for determining the value of_METHODin the request body, for purposes of overriding the body.Question though: wouldn't this type of method-juggling be more appropriately implemented as a middleware rather than living in the core Request object logic, so it becomes an opt-in behaviour?