★ wanayoo — archive 1999 https://github.com/slimphp/Slim/pull/2109Nouvelle recherche | Portail wanayoo
Skip to content

/ Slim

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cookies parser fix #2109

Merged
merged 2 commits into from Dec 20, 2016
Merged

cookies parser fix #2109

merged 2 commits into from Dec 20, 2016

Conversation

@1f7
Copy link
Contributor

@1f7 1f7 commented Dec 20, 2016 •
edited

$header = "foo=bar; testarray=[\"someVar1\",\"someVar2\",\"someVar3\"]";

Cookies.php parseHeaderOriginal(): ["someVar1"
Cookies.php parseHeaderFixed(): ["someVar1","someVar2","someVar3"]
then fixed json_decode: Array
(
    [0] => someVar1
    [1] => someVar2
    [2] => someVar3
)
@1f7
cookies parseHeader fix
Loading status checks…
4add3cf 
test parser
@coveralls
Copy link

@coveralls coveralls commented Dec 20, 2016

Coverage Status

Coverage remained the same at 97.928% when pulling 4add3cf on 1f7:cookie_parser_fix into ff82332 on slimphp:3.x.
@1f7
delete spaces
Loading status checks…
f27e8fb
@coveralls
Copy link

@coveralls coveralls commented Dec 20, 2016

Coverage Status

Coverage remained the same at 97.928% when pulling f27e8fb on 1f7:cookie_parser_fix into ff82332 on slimphp:3.x.
@akrabat akrabat merged commit f27e8fb into slimphp:3.x Dec 20, 2016
3 checks passed
3 checks passed
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.928%
Details
akrabat added a commit that referenced this pull request Dec 20, 2016
@akrabat
Merge branch '1f7-cookie_parser_fix' into 3.x
Loading status checks…
8970fa7 
Closes #2109
@akrabat akrabat added this to the 3.6.1 milestone Dec 20, 2016
@akrabat
Copy link
Member

@akrabat akrabat commented Dec 20, 2016

Thanks!
@akrabat akrabat modified the milestones: 3.7.0, 3.6.1 Dec 20, 2016
@1f7 1f7 deleted the 1f7:cookie_parser_fix branch Jan 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@1f7 @coveralls @akrabat