ipv6 address without port generates warning #2213
Merged
Conversation
akrabat
added a commit
to akrabat/Slim-Http
that referenced
this pull request
May 13, 2017
Forward port of slimphp/Slim#2213
akrabat
added a commit
that referenced
this pull request
May 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
If you query a Url with IPv6 host and no port Slim try to access a not existing array index. I added a testcase that shows how it looks like when the port is omitted and a possible fix for this.
fixes #2209