★ wanayoo — archive 1999 https://github.com/slimphp/Slim/pull/2216Nouvelle recherche | Portail wanayoo
Skip to content

/ Slim

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

determineAuthorization(): HTTP_AUTHORIZATION may be null or an empty string #2216

Merged
merged 2 commits into from May 3, 2017
Merged

determineAuthorization(): HTTP_AUTHORIZATION may be null or an empty string #2216

merged 2 commits into from May 3, 2017

Conversation

@RyanNerd
Copy link
Contributor

@RyanNerd RyanNerd commented Apr 30, 2017

  • determineAuthorization() should check if HTTP_AUTHORIZATION is null OR an empty string
  • Closes issue #2204
Ryan
Check if HTTP_AUTHORIZATION is null *OR* an empty string.
Loading status checks…
f1e4feb
@coveralls
Copy link

@coveralls coveralls commented Apr 30, 2017

Coverage Status

Coverage remained the same at 97.312% when pulling f1e4feb on RyanNerd:fix-2204 into 7d62584 on slimphp:3.x.
@tuupola
Copy link
Contributor

@tuupola tuupola commented Apr 30, 2017

It probably would be cleaner to use empty().
Ryan
Changed logic to use suggested empty() function.
Loading status checks…
a813d70
@coveralls
Copy link

@coveralls coveralls commented Apr 30, 2017

Coverage Status

Coverage remained the same at 97.312% when pulling a813d70 on RyanNerd:fix-2204 into 7d62584 on slimphp:3.x.
@geggleto geggleto self-requested a review May 3, 2017
@geggleto geggleto merged commit d282722 into slimphp:3.x May 3, 2017
3 checks passed
3 checks passed
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.312%
Details
@RyanNerd RyanNerd deleted the RyanNerd:fix-2204 branch May 3, 2017
@akrabat akrabat added this to the 3.8.2 milestone May 13, 2017
akrabat added a commit to akrabat/Slim-Http that referenced this pull request May 14, 2017
@akrabat
Allow for HTTP_AUTHORIZATION to be empty
b60deb5 
Port slimphp/Slim#2216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geggleto geggleto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@RyanNerd @coveralls @tuupola @akrabat @geggleto