★ wanayoo — archive 1999 https://github.com/slimphp/Slim/pull/2309Nouvelle recherche | Portail wanayoo
Skip to content

/ Slim

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send correct status code regardless of location header #2309

Merged
merged 1 commit into from Nov 3, 2017
Merged

Send correct status code regardless of location header #2309

merged 1 commit into from Nov 3, 2017

Conversation

@kelunik
Copy link
Contributor

@kelunik kelunik commented Sep 28, 2017

PHP thinks it's clever, but it isn't. Fixes #1730.
@kelunik kelunik mentioned this pull request Sep 28, 2017
Closed
@coveralls
Copy link

@coveralls coveralls commented Sep 28, 2017

Coverage Status

Coverage remained the same at 93.223% when pulling a14c78e on kelunik:fix-1730 into 403b798 on slimphp:3.x.
@kelunik
Send correct status code regardless of location header
Loading status checks…
a2c93ac 
PHP thinks it's clever, but it isn't. Fixes #1730.
@kelunik kelunik force-pushed the kelunik:fix-1730 branch from a14c78e to a2c93ac Sep 28, 2017
@coveralls
Copy link

@coveralls coveralls commented Sep 28, 2017

Coverage Status

Coverage remained the same at 93.223% when pulling a2c93ac on kelunik:fix-1730 into 403b798 on slimphp:3.x.
@akrabat akrabat merged commit a2c93ac into slimphp:3.x Nov 3, 2017
3 checks passed
3 checks passed
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.223%
Details
akrabat added a commit that referenced this pull request Nov 3, 2017
@akrabat
Merge branch 'kelunik-fix-1730' into 3.x
Loading status checks…
dfcd632 
Closes #2309
@akrabat akrabat added this to the 3.9.0 milestone Nov 3, 2017
@kelunik kelunik deleted the kelunik:fix-1730 branch Nov 3, 2017
@akrabat
Copy link
Member

@akrabat akrabat commented Nov 3, 2017

Also merged to 4.x
@akrabat
Copy link
Member

@akrabat akrabat commented Nov 3, 2017

Thanks @kelunik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@kelunik @coveralls @akrabat