Encode user info #2327
Merged
Encode user info #2327
Conversation
If the username or password includes an `@`, `:` or other reserved characters, they need to be encoded. Fixes #2201
akrabat
added a commit
to akrabat/Slim-Http
that referenced
this pull request
Nov 3, 2017
If the username or password includes an `@` or `:` or other reserved characters, they need to be encoded. Forward ports slimphp/Slim#2327.
akrabat
added a commit
to akrabat/Slim-Http
that referenced
this pull request
Nov 3, 2017
If the username or password includes an `@` or `:` or other reserved characters, they need to be encoded. Fixes slimphp#34 Forward ports slimphp/Slim#2327.
|
Just a note: |
|
@mahagr Now that is a very good question :) I think that they should all have |
|
Also another thing... Should |
|
And from your example: hostname isn't filtered either... |
|
Yes - I would appreciate a PR :) |
|
Re hostname: is there any reason to filter it? |
|
You can use Uri class outside of request to build a new URL to be shown your page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
If the username or password includes an
@,:or other reservedcharacters, they need to be encoded.
Fixes #2201