★ wanayoo — archive 1999 https://github.com/slimphp/Slim/pull/2439Nouvelle recherche | Portail wanayoo
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docbock for Request::getParam() second param's type #2439

Merged
merged 1 commit into from Jun 24, 2018

Conversation

@hhovakimyan
Copy link

@hhovakimyan hhovakimyan commented May 15, 2018

getParam method $default argument type is marked as string, but actually any type of parameters can be passed for $default argument and everything will work. That's why I changed it's type to mixed

`getParam` method `$default` argument type is marked as string, but actually any type of parameters can be passed for `$default` argument and everything will work. That's why I changed it's type to `mixed`
@coveralls
Copy link

@coveralls coveralls commented May 15, 2018

Coverage Status

Coverage remained the same at 97.105% when pulling 4a805ba on hhovakimyan:patch-1 into 0803c9e on slimphp:3.x.

@akrabat akrabat added this to the 3.10.1 milestone May 15, 2018
@akrabat akrabat merged commit 4a805ba into slimphp:3.x Jun 24, 2018
3 checks passed
3 checks passed
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.105%
Details
akrabat added a commit that referenced this pull request Jun 24, 2018
Closes #2439
@akrabat
Copy link
Member

@akrabat akrabat commented Jun 24, 2018

Thanks.

@akrabat akrabat changed the title Change `getParam` method second param type Update docbock for Request::getParam() second param's type Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants