Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed error with zero tensor size in xt::mean #2047
Conversation
|
I've checked failed checks - they crashed because linker can't parse some argument: |
|
anyone? |
|
I don't understand how your changes can have any impact, you are storing calls to size() in local variables and then immediatly use these locals as arguments for mean_division. This is equivalent to the previous code where calls to size are directly used as arguments, but more verbose. |
|
No, code is not equivalent to the previous one.
if |
|
Ha indeed, now I feel a bit embarrassed ;) Thanks for the PR, and the clarification. The failure of azure pipelines is totally unrelated to your change (it seems that we have the same failure for the whole stack), however I would like to fix it before merging any PR. |
9154860
into
xtensor-stack:master
|
No problem |
Checklist
Description
Fixed bug when zero tensor size after moving in xt::mean leads to inf mean values